[WIP] Added setup.py - Githubissues

choderalab / itctools

Tools for setting up ITC experiments in an automated fashion using the Tecan EVO and Auto-iTC 200.

3 stars 6 forks source link

[WIP] Added setup.py #20

Closed bas-rustenburg closed 9 years ago

jchodera commented 9 years ago

Awesome! Thanks!

coveralls commented 9 years ago

Coverage decreased (-0.04%) when pulling 0de491ed6f18662398bb3ea8ba397f9509e2e02e on bas-rustenburg:setup into 40c6556c8e391b59f5ebf4444aa5af6261c2ee77 on choderalab:master.

bas-rustenburg commented 9 years ago

Adding setup.py decreased coverage. Should I modify my coverage command to not include setup.py?

Although I suppose one could write tests for functionality in the setup.py, I am not sure how I would test it. Does anyone know if it is common to write tests for a setup.py?

jchodera commented 9 years ago

Adding setup.py decreased coverage. Should I modify my coverage command to not include setup.py?

Sounds reasonable. Travis is testing it by trying to install the package.

coveralls commented 9 years ago

Coverage remained the same when pulling eb2f1e5ed4fe18ef7ed990c59a6e3f330c06bb54 on bas-rustenburg:setup into 40c6556c8e391b59f5ebf4444aa5af6261c2ee77 on choderalab:master.

bas-rustenburg commented 9 years ago

Will do. I've started work on some simple unit tests, so hopefully I'll be able to increase that coverage score soon! (See https://github.com/bas-rustenburg/itctools/tree/tests)

bas-rustenburg commented 9 years ago

Updated the tests to actually used the installed version of the library. I suppose that is also a verification of a proper installation.

coveralls commented 9 years ago

Coverage decreased (-0.65%) when pulling 1d78e0d1173867ba36286d247cdefc6825f52c72 on bas-rustenburg:setup into 40c6556c8e391b59f5ebf4444aa5af6261c2ee77 on choderalab:master.

coveralls commented 9 years ago

Coverage decreased (-0.77%) when pulling b608a4efb8fc8d924417f315e18b6ed0aaaa82c2 on bas-rustenburg:setup into 40c6556c8e391b59f5ebf4444aa5af6261c2ee77 on choderalab:master.

bas-rustenburg commented 9 years ago

Added the generation of a version.py file (copying most of numpy's approach).

coveralls commented 9 years ago

Coverage remained the same when pulling 18a071bc793925ff1baa4e44bc37cc6e795ef5ec on bas-rustenburg:setup into 40c6556c8e391b59f5ebf4444aa5af6261c2ee77 on choderalab:master.

coveralls commented 9 years ago

Coverage remained the same when pulling 801bb5b2828efd29c090043466b5655b9d8ab5df on bas-rustenburg:setup into 40c6556c8e391b59f5ebf4444aa5af6261c2ee77 on choderalab:master.

bas-rustenburg commented 9 years ago

Decided to kick behave tests out of the coverage score since they don't reflect the coverage of the library. Will be adding unit tests in a separate PR. Any suggestions/comments? Otherwise I think this one is ready to merge.

jchodera commented 9 years ago

Should be good to merge!