search

choderalab / itctools

Tools for setting up ITC experiments in an automated fashion using the Tecan EVO and Auto-iTC 200.
3 stars 6 forks source link

Add missing install dependencies to setup.py #36

Closed jchodera closed 9 years ago

jchodera commented 9 years ago

I added a bunch of missing dependencies to allow me to install python setup.py install and run nosetests.

jchodera commented 9 years ago

I'm not sure what the setup_requires and test_requires fields are in the setup(...) block. Perhaps you can take a look at that?

bas-rustenburg commented 9 years ago

Sure! I believe they are specific to setuptools. Travis seems to work. Appveyor might take a little while, though I don't expect issues.

https://pythonhosted.org/setuptools/setuptools.html

jchodera commented 9 years ago

Should the added dependencies be added to setup_requires?

bas-rustenburg commented 9 years ago

I actually think we do not need that particular line since we're not using distutils extensions. We might as well get rid of it to prevent confusion in the future.

jchodera commented 9 years ago

I actually think we do not need that particular line

Which particular line?

bas-rustenburg commented 9 years ago

The line with the setup_requires statement. install_requires only should also do the trick.

bas-rustenburg commented 9 years ago

Thanks!