choderalab / modelforge

Infrastructure to implement and train NNPs
https://modelforge.readthedocs.io/en/latest/
MIT License
11 stars 4 forks source link

PaiNN implementation #10

Closed wiederm closed 1 year ago

wiederm commented 1 year ago

Description

Sorry that this is again a larger PR than I had anticipated. The main goal is to implement the polarizable interaction neural network, reference: http://proceedings.mlr.press/v139/schutt21a.html .

During the implementation several additional issues arose and fixes are included in this PR. This will be the last of its kind, I promise.

In models.py I have separated the Base class from the Lighing Class, which is now a Mixing.

In schnet.py I have added the SchnetLighning implementation that uses the Mixing Lightning class.

Other changes that are not directly related to the PaiNN implementation are:

Todos

Status

codecov-commenter commented 1 year ago

Codecov Report

Merging #10 (a84c57b) into main (56cfa31) will decrease coverage by 4.19%. Report is 13 commits behind head on main. The diff coverage is 70.19%.

Additional details and impacted files