choderalab / modelforge

Infrastructure to implement and train NNPs
https://modelforge.readthedocs.io/en/latest/
MIT License
9 stars 4 forks source link

change to zenodo api #31

Closed chrisiacovella closed 8 months ago

chrisiacovella commented 8 months ago

Zenodo just rolled out some changes to their API, which breaks some of the code in model forge

https://help.zenodo.org/docs/about/whats-changed/

The main change impacting model forge is to the urls.

For example:

        "https://zenodo.org/record/8222043/files/SPICE-1.1.4.hdf5"

now becomes

        "https://zenodo.org/records/8222043/files/SPICE-1.1.4.hdf5"

If you access a record via the web it redirects, but you don't get such redirects via python requests.

Several other changes to the API have also occurred which impact functions I had written, but we ultimately are not using due to changes in how we approached things. These are functions that would take a DOI or zenodo record id and return the files to download. My plan is just to remove those functions in the PR #30 I'm working on now. If they are eventually useful, we can always re-add them and update, but I'm not see much utility at the moment.