Closed wiederm closed 1 year ago
I personally think that this parent class is a slight overkill.
For the parent class I think it should serve the follow purposes:
@wiederm I'm still a bit confused about the questions I've asked above---could you justify the necessity of those design choices a bit more? Thanks!
Description
This PR provides an NNP base class, NNPBase, to provide a flexible and extensible foundation for implementing various neural network potentials. It also introduces an implementation of the SchNet architecture for predicting quantum mechanical molecular properties.
Changes:
Key Files: