search

choderalab / mtenn

Modular Training and Evaluation of Neural Networks
MIT License
5 stars 1 forks source link

Fix gitignore version #19

Closed hmacdope closed 8 months ago

hmacdope commented 1 year ago

Fixes #16

hmacdope commented 1 year ago

@mikemhenry could I snag a review here :)

codecov-commenter commented 1 year ago

Codecov Report

Merging #19 (82ca714) into main (d764657) will decrease coverage by 0.48%. The diff coverage is n/a.

mikemhenry commented 1 year ago

This should work, I will give it a test later today

hmacdope commented 1 year ago

I found i had to do a pip install -e . install rather than pip install . build so that git-describe could find the right spot. Have you had this issue at any point?

mikemhenry commented 1 year ago

Hmm, try adding a tag (don't push it) and see if with a pip install . the version you expect is reported? I will look into this as well

hmacdope commented 1 year ago

Yeah it seems to complain that git describe isn't working if not a pip install -e .

hmacdope commented 8 months ago

Shouldn't do this.