choderalab / openmoltools

An open set of tools for automating tasks relating to small molecules
MIT License
63 stars 30 forks source link

Implement handling of non-three-point water models #143

Open davidlmobley opened 9 years ago

davidlmobley commented 9 years ago

Longer-term, we probably want to implement the ability to handle non-three-point water models. This will take some substantial work, since amber.build_mixture_prmtop and packmol.pack_box work typically from .mol2 files (i.e. for water) and for four or five (or other) point water models we won't have a .mol2 file to work from, and there will be other architectural changes as well.

142 addresses issue #134 for three-point water models, but more general water models will require more rethinking.

I would love input on the best way to do this. Changes will be needed in at least two places:

davidlmobley commented 9 years ago

A likely solution is to use the approach mentioned by @jchodera in #142 to help with this. Specifically:

Note that simtk.openmm.app.Modeller offers a method addExtraParticles to add any missing extra sites for multipoint waters defined with OpenMM ffxml files. I'm not sure if it is feasible to utilize this in the pipeline or not.