Closed dnguyen1196 closed 4 years ago
Great thanks, I will review tomorrow with a bit more time on my hands.
Thanks this looks nice! Let me take a look at the details in just a bit.
btw all the macOS tests are failing because of RAM issue or something. let's just disable them since it's distracting.
Reference issues: #26
A more modular implementation of GVAE that is more compatible with our
Net
class. Adapted from https://github.com/zfjsail/gae-pytorch/tree/master/gaeA quick look at the interface:
A training file in
gvae_exp.py
andtrain.py
. The current training scheme loops through each molecule (1186 of them in the esol data set). However, most of these molecules make up small graphs. As a result, there is over fitting going on as training loss can be driven to 0 but validation and testing "scores" is low.Also comes with utility function that performs "partition" of the graph into train/test/validation edges. Note that this implementation of VGAE (and the formulation introduced in the Kipf and Welling 16 paper) was geared towards link prediction. Therefore, various utilties are implemented to facilitate this task.