search

choderalab / saltswap

Package to fluctuate the number of counterions in an OpenMM simulation
MIT License
6 stars 3 forks source link

Add continuous integration via travis and appveyor #8

Closed jchodera closed 7 years ago

jchodera commented 7 years ago

Addresses #4

jchodera commented 7 years ago

Looks like the rest are real errors, @gregoryross.

One of them is just an issue where you force the CUDA platform. If this is a slow test, you might want to skip it with @attr('slow'). If not, you should probably let OpenMM pick the fastest platform for you.

I'll let you finish this up, @gregoryross! The tests are running.

jchodera commented 7 years ago

@gregoryross : Just a reminder that this PR is complete, but the tests found there were issues with the code due to missing imports. I'm done with it, so you should pick it up and fix the issues at your convenience.

bas-rustenburg commented 7 years ago

@gregoryross , let me know if you're interested in monitoring test coverage from your travis builds. This might be a good moment to add it in. I've found the codecov reports handy https://github.com/choderalab/protons/pull/89#issuecomment-305305496.

jchodera commented 7 years ago

Woohoo! Looks like test pass!

gregoryross commented 7 years ago

@bas-rustenburg, adding a code coverage report sounds a like good idea. Grab me when you're free?

bas-rustenburg commented 7 years ago

Cool, might end up being tomorrow. We can do this in a separate PR if that is easier.

gregoryross commented 7 years ago

@bas-rustenburg, as you, it'll probably be easier to save the codevcov reports for another PR.