search

choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 57 forks source link

One Css file per font #19

Closed shprink closed 8 years ago

shprink commented 9 years ago

Hi,

thanks for this lib. I have a suggestion. If you use tools like Webpack or Browserify you may want to only get one type of font and not all of them.

With webpack if you require('roboto-fontface') you will automatically get all font files (kinda big).

I suggest you separate every type of font in different css files then we will be able to only require what we need like this: require('roboto-fontface/css/Roboto-ThinItalic.css')

choffmeister commented 9 years ago

That is true. But I would still like to keep the all-in-one files. Can you create a PR that adds the individual CSS files?

shprink commented 9 years ago

Do not really have time for that sorry, just keep it in mind ;)

lijunle commented 8 years ago

+1 here. :)

mspanc commented 8 years ago

I've created PR.

mspanc commented 8 years ago

Now it is one file per weight, that includes both straight and italic, but if you think they should be separate, too, let me know.

choffmeister commented 8 years ago

Thx @mspanc for implementing this! Have released a new version 0.4.4 to bower and npm.

choffmeister commented 8 years ago

And 0.4.5, because I forgot to update bower.json in 0.4.4 :)