search

choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 56 forks source link

File globs #26

Closed robertmain closed 8 years ago

robertmain commented 8 years ago

Use file globs instead of selecting every single file manually

choffmeister commented 8 years ago

Hi. Thanks for the PR. Did you check, what the output of bower list --path is when using the glob?

robertmain commented 8 years ago

Is it not working for you?

choffmeister commented 8 years ago

Did tested it:

$ bower install roboto-fontface
# apply your changes to bower_components/roboto-fontface/{.,}bower.json
$ bower list --paths
$ bower list --paths

Output is

  'roboto-fontface': [
    'bower_components/roboto-fontface/css/*.*',
    'bower_components/roboto-fontface/fonts/*.*'
  ]

So bower itself is not resolving the globs. Sorry, but I would like to have the bower main array to contain an exact list of files, that one has to include into his project (as part of a bundling step or so) to use this fontface. The maintainence of this explicit file list is not nice, I know, but I does not change often anyway.

I will close this PR for now. Feel free to reopen, if you disagree.