search

choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 57 forks source link

Created separate SCSS/LESS files for different weights #27

Closed mspanc closed 8 years ago

mspanc commented 8 years ago

Hello, in response to https://github.com/choffmeister/roboto-fontface-bower/issues/19 I've created separate SCSS/LESS files for different weights

choffmeister commented 8 years ago

Hi, thx for your PR. Giving the possibility to only include the font/weight one needs, is a good addition. But with your commit there are dozen files to that are almost the same.

You might want to take a look here (https://github.com/choffmeister/roboto-fontface-bower/pull/23#discussion_r44274573). Do u think u could use the mixin style so that we only have 4 files (main less, mixin less, main scss, mixin scss) to keep the duplication as low as possible?

mspanc commented 8 years ago

@choffmeister I implemented your suggestions

choffmeister commented 8 years ago

Thx! I merged it and added a small test suite, that less/sass compiles every file. Will enable circleci testing on it and then release as 0.4.4