search

choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 56 forks source link

[Added] Roboto Condensed and tests #28

Closed Purush0th closed 8 years ago

Purush0th commented 8 years ago

[Added] Roboto Condensed [Added] test.html - Has tests for all fonts [Modified] Folder structure and mixins to add more font variants of roboto

Bear with me for lots of files showing deleted/modified. Its just a folder structure changed to accommodate more Roboto font variants.

Please run test.sh and test.html to make sure everything working as expected.

Thanks, Purushothaman

choffmeister commented 8 years ago

Thank you for the PR. Will look into it as soon as I have time.

One thing I already noticed: Is the moving of the .scss/.less files really necessary? This breaks with all previous versions. I am not saying, that I am totally against it, but if we do this, then there should be really good reasons...

Purush0th commented 8 years ago

Hi @choffmeister,

Thanks for considering the PR. Yeah I too worry it would break previous version's structure.

Its just a separation of concerns to group related files of a particular font variant. where the common 'mixins' will stay outside.

Feel free to modify the structure if needed. Or we can display upgrade notice regarding the change. Will that work?

Thanks, Purushoth

choffmeister commented 8 years ago

Published as 0.5.0

Purush0th commented 8 years ago

That's great :+1: