choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 57 forks source link

added 'main' array pointing to css & font files for better integration with build systems #3

Closed jmcmichael closed 10 years ago

jmcmichael commented 10 years ago

I was attempting to use roboto-fontface-bower with gulp-bower-files, but it failed with the error 'The bower package jfm-roboto-fontface has no main file(s)'. After adding the main array to bower.json, it is able to find the required files and proceed without having to provide gulp-bower-files with the file locations in an overrides property. I assume that this update will also allow robot-fontface-bower to better work with other build systems like Brunch.

choffmeister commented 10 years ago

Thanks for the PR. It did some research on how the main field is supposed to be used and compared with many other bower packages. I guess many of them use it in the wrong way. At https://github.com/bower/bower.json-spec they say the field should contain the main files needed, but preprocessor files (like Less) should not go in here. Hence your solution seems like a perfect fit to me.

choffmeister commented 10 years ago

I have released your changes as v0.1.5