search

choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 56 forks source link

Update roboto-font-path to be relative to the package name #39

Closed jgornick closed 7 years ago

jgornick commented 7 years ago

This allows the mixin to avoid using relative URLs. This is troublesome when using tools like webpack.

choffmeister commented 7 years ago

Hmm. But this only works with webpack. And this package is not webpack specific. Also, you can just override the $roboto-font-path variable to be ~roboto-fontface/fonts without having to change it here in the package itself. This way you have what you want and this package stays compatible with non-webpack use cases.

jgornick commented 7 years ago

@choffmeister Has a good point. Closing this pull request. Thanks!