choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 56 forks source link

The fontface path is /font and should be ../font #7

Closed pwnjack closed 9 years ago

pwnjack commented 9 years ago

As stated, when installing the package via Bower the fontface path points to font/path-to-font-file while usually the fontface css file is inside the css folder, so it should be ../font/path-to-font-file.

Just saying.

choffmeister commented 9 years ago

I would say the CSS file is correct this way. When someone installs/downloads this package, the fonts are indeed relative to the CSS file position at font/... and not at ../font/.... If one decides to move the CSS file, he has to manually adopt the paths. For the LESS and SCSS version this can be easily done by overriding the corresponding variable. Sadly, CSS does not provide such convenience...

pwnjack commented 9 years ago

Just to be clear.

I usually use:

root
|-- js
|-- css
|-- fonts

You are saying to use:

root
|-- js
|-- css
|-- |-- fonts

I've got it right?

I mostly see my situation. (Bootstrap etc.)

Anyway, it's just a suggestion.

btw, thanks for the package! ;)

choffmeister commented 9 years ago

I don't want to be opinionated one anyones project stucture at all. If one does bower install roboto-fontface then this

project/
  bower-components/
    roboto-fontface/
      fonts/
        Roboto-Black.eot
        ...
      roboto-fontface.css
      ...
    ...

is what you get. Hence if one includes the roboto-fontface.css file from this location as style, then the paths are correct. And that is what counts for me: Installing via bower and including style from the default location must work out of the box.

If you choose to restructure the folder structure, then you have to adopt the CSS file.

Anyway, thx for your thanks :)

pwnjack commented 9 years ago

Clear! I got the point, Thanks for clarifying. We can close this.

Cheers! ;)

choffmeister commented 9 years ago

You're welcome!