choffmeister / roboto-fontface-bower

Bower package for the Roboto font-face
Apache License 2.0
153 stars 57 forks source link

Problem compiling less file #8

Closed nikoskalogridis closed 9 years ago

nikoskalogridis commented 9 years ago

compiling roboto-fontface.less through less creates the following incorrect output:

@font-face {
  font-family: 'Roboto';
  src: url('fonts/Roboto-#000000.eot');
  src: url('fonts/Roboto-#000000.eot?#iefix') format('embedded-opentype'), url('fonts/Roboto-#000000.woff2') format('woff2'), url('fonts/Roboto-#000000.woff') format('woff'), url('fonts/Roboto-#000000.ttf') format('truetype'), url('fonts/Roboto-#000000.svg#Roboto') format('svg');
  font-weight: 900;
  font-style: normal;
}
@font-face {
  font-family: 'Roboto';
  src: url('fonts/Roboto-#000000Italic.eot');
  src: url('fonts/Roboto-#000000Italic.eot?#iefix') format('embedded-opentype'), url('fonts/Roboto-#000000Italic.woff2') format('woff2'), url('fonts/Roboto-#000000Italic.woff') format('woff'), url('fonts/Roboto-#000000Italic.ttf') format('truetype'), url('fonts/Roboto-#000000Italic.svg#Roboto') format('svg');
  font-weight: 900;
  font-style: italic;
}

replacing the following lines

.roboto-font-pair(Bold, 700);
.roboto-font-pair(Black, 900);

with

.roboto-font-pair('Bold', 700);
.roboto-font-pair('Black', 900);

seems to solve the issue

nikoskalogridis commented 9 years ago

Sorry, it seems the offending line is the last one. No need to enclode Bold in single quotes.

choffmeister commented 9 years ago

Thanks for contribution. Will look at the problem tomorrow.

Am 26.10.2014 um 21:50 schrieb Nikos Kalogridis notifications@github.com:

Sorry, it seems the offending line is the last one. No need to enclode Bold in single quotes.

— Reply to this email directly or view it on GitHub.

choffmeister commented 9 years ago

Released as v0.2.5. I have tested the compiling again with both, LESS and SASS in version:

$ lessc --version
lessc 1.7.5 (Less Compiler) [JavaScript]
$ sass --version
Sass 3.3.7 (Maptastic Maple)
choffmeister commented 9 years ago

See #2