search

choigv / reflections

Automatically exported from code.google.com/p/reflections
Do What The F*ck You Want To Public License
0 stars 0 forks source link

TypesScanner.java deleted - Breaks backwards compatibility #150

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. new ConfigurationBuilder().setScanners(new TypesScanner());

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
0.9.9-RC1
Problem occurred in commit 167:
https://code.google.com/p/reflections/source/detail?r=167

Please provide any additional information below.
As build 0.9.9 is a patch release compared to version 0.9.8, it should not 
break backward compatibility. PlayFramework2 is an example of a project that 
depends on TypesScanner.java

See issue on the Play2-War project caused by the deletion of TypesScanner.java:
https://github.com/dlecan/play2-war-plugin/issues/167

If TypesScanner.java is to be removed in the future, it should be versioned as 
a Major release eg 1.0.0.
See rules on Semantic Versioning:
http://semver.org/

Thanks
Kevin

Original issue reported on code.google.com by kevinshe...@gmail.com on 9 Jul 2013 at 11:14

GoogleCodeExporter commented 9 years ago 
I dont mind the TypesScanner dissappearing if there is equivalent functionality 
available. Can you add something to the reflections lib project homepage 
describing how you may find all the types that are available? What the 
TypesScanner provided before. Do we just use the SubTypesScanner(false)?

Just a thought. It took me a while to figure out how to move away from the 
TypesScanner.

Original comment by sbarls...@gmail.com on 9 Aug 2013 at 10:13

GoogleCodeExporter commented 9 years ago 
Do the comments about semantic versioning only apply once a project has reached 
version 1? Anything before 1.0.0 is alpha/beta and anything goes.

Original comment by sbarls...@gmail.com on 9 Aug 2013 at 10:14

GoogleCodeExporter commented 9 years ago 
In general yes, before 1.0.0 is pre-release. But I don't think this project has 
been following Semantic Versioning up to now. It has been going for about 5 
years and is used in many production environments so I think it should be 
treated as a stable production-ready product.

I'm happy for TypesScanner to be dropped but would prefer if it was in version 
1.0.0.

Putting it back into the 0.9.9 release would allow me to deploy the Play 
Framework on Websphere which was my original problem.

Original comment by kevinshe...@gmail.com on 9 Aug 2013 at 12:55