chok / sfMelodyPlugin

Allow to communicate with many services(google, yahoo...) throw OAuth
MIT License
45 stars 21 forks source link

OAuth Exceptions are not thrown #25

Open ibolmo opened 13 years ago

ibolmo commented 13 years ago

From a quick look into the get and other request implementations they're not checking for an error returned by the service.

There's two (immediate) cases where this would have helped with debugging some problems I had:

  1. I didn't notice that my secret was out dated because the error returned by OAuth via getAccessToken was not thrown.
  2. Because the token was invalid I couldn't get the email scope (which is required by sfGuard) so the User was never created -- the actual error shown was that email_address failed validation (not_null).