search

chokkan / crfsuite

CRFsuite: a fast implementation of Conditional Random Fields (CRFs)
http://www.chokkan.org/software/crfsuite/
Other
641 stars 208 forks source link

fix: call apple function when apple #115

Closed franklevasseur closed 11 months ago

franklevasseur commented 4 years ago

this problem is also the one that made me right this PR, although both PR solve different problems.

Again, the code is self explanatory...

the __STDC_VERSION__ >= 201112L was true, but I run OSX so I wanted to execute the second branch of this if statement.

write me if you have any questions, but I won't check my messages until next monday!

have a good weekend,

François

cynthia commented 4 years ago

Thank you for the pull request. I'll review this and your other PRs and try to land the patches if they look good.

cynthia commented 4 years ago

Which Xcode/clang version were you using to trigger this problem? This looks like it'd be fine for clang, but I'll have to check how it works with gcc on macOS.

franklevasseur commented 4 years ago

Which Xcode/clang version were you using to trigger this problem? This looks like it'd be fine for clang, but I'll have to check how it works with gcc on macOS.

I'm sorry, but I can't answer right now as the Apple computer I was using does not belong to me and is not in my possession at this moment. I'll try to get my hand on it to recreate the problem (it's already been few weeks.) However, maybe this can help you: here is the binding.gyp file I have used to build crfsuite on all OS and distributions: https://github.com/botpress/node-crfsuite-napi/blob/master/binding.gyp.

François

nbrachet commented 3 years ago

I run into this problem with XCode 12.2 / clang-1200.0.32.27.