Return new tagger instances for each call to get_tagger().

chokkan / crfsuite

CRFsuite: a fast implementation of Conditional Random Fields (CRFs)

http://www.chokkan.org/software/crfsuite/

Other

647 stars 208 forks source link

Return new tagger instances for each call to get_tagger(). #36

Closed tavianator closed 8 years ago

tavianator commented 9 years ago

Fixes https://github.com/chokkan/crfsuite/issues/35

usptact commented 9 years ago

The training goes smooth. The tagging not. I get the predictions printed out and (at the end?) it segfaults. Can you please check?

tavianator commented 9 years ago

Hmm, this one I can't reproduce. Can you share your training and tagging command lines? And possibly the data and/or model? Thanks!

usptact commented 9 years ago

I realized that I tried to patch this branch code with your changes (I noticed that your fork has much more commits). May be I messed up by manually modifying the code. I must check how I copied it.

The command-line arguments are standard: crfsuite tag -m model file.features The binary built using this repository code tags everything fine.

tavianator commented 8 years ago

@chokkan I rebased this to fix the conflict. Thanks for merging all those PRs by the way!

chokkan commented 8 years ago

@tavianator Thank you very much for fixing the conflict. It was very helpful.