choko-org / redux-boot

Modular Redux bootstrap with asynchronous side-effects.
MIT License
126 stars 7 forks source link

Redux, Redux Actions and Redux Promise should be peer dependencies? #26

Open sebas5384 opened 8 years ago

sebas5384 commented 8 years ago

If we look at projects like react-redux, redux-actions or redux-promise we can notice that their are using peerDependencies for the redux-* dependencies.

I think we should follow this pattern because redux it self for example must be a direct dependency of the project which is using or implementing these libs. It's more easy to know what dependencies the project has, but at the same time removes some kind of abstractions which could help legibility.

Should we move redux, redux-actions and redux-promise to peerDependencies?

sebas5384 commented 7 years ago

Redux Actions now required defaultState in the handleActions function, so we need to considerate to improve this dependency. https://github.com/acdlite/redux-actions/pull/127 https://github.com/acdlite/redux-actions/issues/23