Redux actions and tests bug fix

choko-org / redux-boot

Modular Redux bootstrap with asynchronous side-effects.

MIT License

126 stars 7 forks source link

Redux actions and tests bug fix #33

Closed arojunior closed 7 years ago

arojunior commented 7 years ago

defaultState in handleActions is used to initialState, but in redux-boot you can pass the initial state when you start the app const app = boot(initialState, modules) or using BOOT action in a reducer. So defaultState from handleActions is not needed. I just passed an empty object to solve this error.

sebas5384 commented 7 years ago

Hey @arojunior seems good to me!! and all the tests are passing 👍 but I think we need to discuss more about the code formatting in another issue, could you separate those modifications in another PR ?

After that I think we could merge it and do a new release!

Thanks o/

arojunior commented 7 years ago

Sorry about that. It's because of that "Format files on save" thing from Prettier. I just made another commit with the original code formatting.

sebas5384 commented 7 years ago

@arojunior all good! this PR is in the new release 1.1.3 thanks!