Fixed macOS build - Githubissues

cholcombe973 / block-utils

Rust utilities for working with block devices

MIT License

22 stars 17 forks source link

Fixed macOS build #30

Closed VladasZ closed 3 years ago

VladasZ commented 3 years ago

from_udev_device and get_parent_name methods break build on macOS. I muted them with cfg. All usages of these methods were under #[cfg(target_os = "linux")] anyway, so it won't change anything on other platforms. Also i added .idea/ to .gitignore to ignore CLion data.

VladasZ commented 3 years ago

Hi @cholcombe973 ! Thanks for approving. Could you please release a new version? Also what do you think about adding macOS and Windows CI job? It will prevent such issues in the future. I can create a new PR with such jobs.

cholcombe973 commented 3 years ago

I think adding a macos and windows ci job sounds great. If you'd be willing to create a pr i'd really appreciate it. I'll cut a release in a few mins