cholcombe973 / block-utils

Rust utilities for working with block devices
MIT License
22 stars 17 forks source link

Add new function to nvme module - get_log() #44

Open robsonsmartins opened 1 year ago

robsonsmartins commented 1 year ago

The proposal is to add a new function to the nvme module: get_log(), which is capable of calling the command line nvme get-log <device_path> -i <log_id> -l <log_len> -b and returning the requested log as a Vec::<u8> (a byte array).

The interface of this function will be:

pub fn get_log(dev: &Path, id: u8, len: u16) -> BlockResult<Vec<u8>> {}

PR: #45

Reference: https://manpages.debian.org/testing/nvme-cli/nvme-get-log.1.en.html

cholcombe973 commented 1 year ago

Thanks for doing this. I've merged the PR. Would you like me to cut a release or are there more PRs you think you'd like to add first?

robsonsmartins commented 1 year ago

I think this is a good time to create a release tag with the changes already incorporated. Thanks!