search

choldgraf / ecogtools

A collection of tools for analyzing electrocorticography data
BSD 2-Clause "Simplified" License
17 stars 4 forks source link

FIX: audio.py #3

Open kingjr opened 8 years ago

kingjr commented 8 years ago

I'm looking for compress_signal; can you tell me where to find it?

kingjr commented 8 years ago

from scipy.signal import fftconvolve is missing

kingjr commented 8 years ago

You should get linter-flake8 with atom, you'll quickly catch a lot of issues ;)

kingjr commented 8 years ago

Apart from the fact that I jumped the non linear compression step, I didn't manage to actually get a spectrum, just zeros.

choldgraf commented 8 years ago

ah shit - I managed to miss these notifications entirely...I'll look into the code now

choldgraf commented 8 years ago

I'm looking for compress_signal; can you tell me where to find it?

It's in sig.py...I added an import now

from scipy.signal import fftconvolve is missing Not anymore :D

You should get linter-flake8 with atom, you'll quickly catch a lot of issues ;) I've been using a pep8 linter with sublime text, is the one from atom any different/better? Actually, is Atom any different/better? I've tried it but haven't done so for long.

Re: the output, it probably broke when I ported it over...working on it now

choldgraf commented 8 years ago

OK, just ran the latest version on an audio waveform and it wave me the expected output:

image

That was run on a single raw audio waveform. Do you still have issues with the output being unintelligible? (btw, I recommend using the 'nsl' spectrogram because the DRNL one is more finnicky...I'm thinking about deleting it.

Also I cleaned up the docstrings a little bit, though still a lot more to do.