search

choldgraf / sphinx-social-previews

Generate a social media preview image from page metadata with Sphinx
Other
4 stars 0 forks source link

Combine into sphinxext-opengraph? #1

Closed TheTripleV closed 1 year ago

TheTripleV commented 2 years ago

Hi,

This extension seems very cool. I noticed you added sphinxext-opengraph as a dependency. Would you want to combine this functionality into sphinxext-opengraph?

choldgraf commented 2 years ago

I'd be more than happy to if the maintainers of that project thought it were in scope. Where's the place to have that conversation?

Ideally, I could just delete this repository and use the opengraph extension for this functionality 👍

TheTripleV commented 2 years ago

Great! We do think that it would be a good addition. You can make a PR to https://github.com/wpilibsuite/sphinxext-opengraph/ . I think your __init__.py can mostly slot into opengraph's __init__.py. Swapping over to the existing title and description parsing would be the biggest change.

choldgraf commented 2 years ago

OK cool - I'll open up an issue over there to discuss and we can take it from there

choldgraf commented 2 years ago

Issue is here:

choldgraf commented 1 year ago

closing this one in favor of a more detailed version here:

mrocklin commented 1 year ago

As a fly on the wall and downstream user let me just say that I'm excited about this functionality becoming more widespread

choldgraf commented 1 year ago

Me too!