Spherical Collapse gravity test currently failing

cholla-hydro / cholla

A GPU-based hydro code

https://github.com/cholla-hydro/cholla/wiki

MIT License

60 stars 32 forks source link

Spherical Collapse gravity test currently failing #218

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

The tGRAVITYSYSTEMSphericalCollapse.CorrectInputExpectCorrectOutput and tPARTICLESSYSTEMSphericalCollapse.CorrectInputExpectCorrectOutput system tests are currently failing on dev. Tested on C-3PO

evaneschneider commented 1 year ago

PR #223 should fix this.

bcaddy commented 1 year ago

It looks like PR #223 fixed the gravity test but not the particles test

evaneschneider commented 1 year ago

That is correct. The particles test is still broken in both main and dev, although now the difference is more like 1e-12. I think we should create a separate issue for that since it's a different test.

bcaddy commented 1 year ago

Will do