cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Integer Conversion issue in Testing Utilities #234

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

testingUtilities::nearlyEqualDbl has an integer conversion bug. It accepts type int when an internal function (testingUtilities::ulpsDistanceDbl) return type int64_t and this can lead to truncation issues when large ULP errors are in play. I've fixed this issue in my fork and a PR will be in shortly along with another minor fix.

bcaddy commented 1 year ago

Fixed with PR #235