search

cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Refactor HLLD solver with structs #237

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

This makes passing all the variables around much simplier, makes the solver much more readable, and enables us to put pretty much everything into testable functions.

bcaddy commented 1 year ago

I found a weird memory access issue with this. Please disregard this PR until I get the issue figured out

bcaddy commented 1 year ago

The memory issue has been fixed in commit 334aa64 and so this is ready to go again