cholla-hydro / cholla

A GPU-based hydro code

https://github.com/cholla-hydro/cholla/wiki

MIT License

60 stars 32 forks source link

Remove functions associated with H correction on CPU from global.cpp and global.h #240

Closed evaneschneider closed 9 months ago

ityashag commented 1 year ago

can you please elaborate more about this issue

evaneschneider commented 1 year ago

Sure! Right now there is a function defined in global that was associated with the old CPU version of Cholla. Most of that code was successfully deleted, but we missed this function:

ifndef CUDA

/! \fn Real calc_eta(Real cW[], Real gamma) \brief Calculate the eta value for the H correction. / extern Real calc_eta(Real cW[], Real gamma);

endif

It just needs to be deleted in both files.

evaneschneider commented 9 months ago

Fixed in PR #342