Closed bcaddy closed 1 year ago
Just copy-pasting the error log here:
/__w/cholla/cholla/src/particles/particles_boundaries_gpu.cu:84:19: error: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals,-warnings-as-errors]
bool transfer = 0;
^
false
/__w/cholla/cholla/src/particles/particles_boundaries_gpu.cu:88:44: error: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals,-warnings-as-errors]
if (side == 0 && pos < d_min) transfer = 1;
^
true
/__w/cholla/cholla/src/particles/particles_boundaries_gpu.cu:89:45: error: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals,-warnings-as-errors]
if (side == 1 && pos >= d_max) transfer = 1;
^
true
Looks like there were some non-hydro instances of modernize-use-bool-literals
This is ready for merging. Thanks to @alwinm for copying the error logs.
using namespace
and add proper namespace qualifiers to statementsgoogle-build-using-namespace
clang-tidy checkwhile(1)
withwhile(true)
modernize-use-bool-literals
clang-tidy checkmisc-unused-parameters
clang-tidy check since it causes too many issues with all our ifdefsClose #233