cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Remove `using namespace` and `while(1)` #245

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

Close #233

alwinm commented 1 year ago

Just copy-pasting the error log here:

/__w/cholla/cholla/src/particles/particles_boundaries_gpu.cu:84:19: error: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals,-warnings-as-errors]
  bool transfer = 0;
                  ^
                  false
/__w/cholla/cholla/src/particles/particles_boundaries_gpu.cu:88:44: error: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals,-warnings-as-errors]
  if (side == 0 && pos < d_min) transfer = 1;
                                           ^
                                           true
/__w/cholla/cholla/src/particles/particles_boundaries_gpu.cu:89:45: error: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals,-warnings-as-errors]
  if (side == 1 && pos >= d_max) transfer = 1;
                                            ^
                                            true

Looks like there were some non-hydro instances of modernize-use-bool-literals

bcaddy commented 1 year ago

This is ready for merging. Thanks to @alwinm for copying the error logs.