cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Remove outflow boundary condition diode for MHD #252

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

Disable diode outflow boundaries for MHD

Since MHD needs a larger stencil the diode in the outflow BC's was causing issues. After discussion with @evaneschneider the diode has been disabled for MHD builds.

Clang Tidy

Minor tweaks to fix clang-tidy's readability-qualified-auto and clang-analyzer-optin.cplusplus.UninitializedObject checks.

The readablity check was fixed by commenting out some currently used code, it's not deleted since it will be used again when MHD is finished; at which time the actual error will be fixed.

The clang-analyzer check was fixed by initializing some member variables in the OneTime class. @alwinm, I'd like you to take a look at this and make sure I haven't broken anything.

Other

alwinm commented 1 year ago

initializing some member variables in the OneTime class.

This looks great to me! I think all those things were left uninitialized because they get set/overwritten later anyway.