search

cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

`bugprone-signed-char-misuse` and removing all C code/build #253

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

The clang-tidy check bugprone-signed-char-misuse only shows up in our singular .c file which exists solely to implement the MPI_Comm_node function. This function is used to set the global variable node which is never used. Removing this means we can fix this warning and get rid of the singular C file and all the associated build complexity that comes with generating a multi-language binary.

I'm planning to work on this during our hack session this week.

bcaddy commented 1 year ago

We might be able to incidentally fix some other clang-tidy checks if they only show up in the .c file, I'll check that when I work on this

bcaddy commented 1 year ago

There weren't any others that were only in the C files

bcaddy commented 1 year ago

Closed with PR #259