cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Restore & refactor `MPI_Comm_node` function #269

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

This restores the MPI_Comm_node function removed in PR #259 and which caused issue #266. While the return of that function was unused it did play an important roll in arranging MPI ranks for Cholla. This PR restores a refactored version of the function that is a bit simpler with the unused bit cut out.

Shout out to @helenarichie for finding the bug and @evaneschneider for identifying what needed to be fixed.

closes #266