cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Convert all indexing variables to `size_t`/`ptrdiff_t` #271

Open bcaddy opened 1 year ago

bcaddy commented 1 year ago

Currently many of the indexing variables we use are of type 'int' when they should be size_t (or ptrdiff_t if they're a difference). This could potentially lead to issues with the range of int as the size of VRAM on GPUs grows and this change would allow us to enable the following clang-tidy checks:

This conversion wouldn't be too difficult but would be time consuming and would be a good project for a new student/collaborator to become familiar with the code.

See this discussion for the original discussion on the topic.