Add Advecting Field Loop test & initial conditions

cholla-hydro / cholla

A GPU-based hydro code

https://github.com/cholla-hydro/cholla/wiki

MIT License

60 stars 32 forks source link

Add Advecting Field Loop test & initial conditions #273

Closed bcaddy closed 1 year ago

bcaddy commented 1 year ago

Summary

Example parameter file in examples/3D/advecting_field_loop.txt
New parameter "R" for the radius of the field loop
New initial conditions type Advecting_Field_Loop and an initializing function of the same name
New MHD system test for the advecting field loop
New function for initializing the magnetic field from the vector potential and a test to go with it
Update Grid3D::AllocateMemory to use grid_enums
Fix a typo in the .clang-tidy file

Fixes #280

bcaddy commented 1 year ago

I've run all the tests and clang-tidy manually and this PR passes everything. IMO this should be merged since it passes all the tests and contains a bug fix for issue #280.

evaneschneider commented 1 year ago

Looks good to me.