search

cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Chemistry builds not compiling on dev #281

Closed evaneschneider closed 1 year ago

evaneschneider commented 1 year ago

PR #277 added two utility function calls to chemistry_functions.cpp, but the headers aren't included, so chemistry builds do not compile. Adding the headers fixes the issue (but I haven't done it yet on dev, only on RT, which will not get merged in soon).

bcaddy commented 1 year ago

I'll fix this. Should we add a chemistry build to our tests?

evaneschneider commented 1 year ago

Yeah, I think that's a good idea. We should probably spend a hack session looking at what code is / isn't covered in the current build matrix, and try to add whatever builds we need to get as much of the code covered as possible.

bcaddy commented 1 year ago

Fixed in PR #283