search

cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
65 stars 32 forks source link

Turn on clang-tidy check for function naming and change function names to pass check #310

Closed helenarichie closed 1 year ago

helenarichie commented 1 year ago

For some reason that's not currently clear to me, clang-tidy only catches some instances of function names not conforming to the Upper_Snake_Case naming convention that we've chosen. I've corrected all of the functions that the check was failing for (and others that I happened to catch while doing this) and the check now passes.

For the most part, it was straightforward to choose new versions of the function names to conform to our naming standard, but there are a few cases that I could use a second opinion on. In particular, there were a few function names in models/disk_ICs.cpp that I didn't understand the meaning of, so the new names that I gave them might not be the best.

bcaddy commented 1 year ago

All the MHD and testing stuff looks good to me.

evaneschneider commented 1 year ago

I think this one is good to go once it's merged with the updated version of dev.

helenarichie commented 1 year ago

Okay, this is ready to go. I resolved the merge conflicts (42fdb67) and updated the function calls/new definitions to pass the function naming check (2c0b6e2). I also had to make a few extra commits for formatting and updating my test data submodule.