cholla-hydro / cholla

A GPU-based hydro code

https://github.com/cholla-hydro/cholla/wiki

MIT License

60 stars 32 forks source link

Fix off by 1 error in 1D & 2D Riemann initial conditions #314

Closed bcaddy closed 11 months ago

bcaddy commented 11 months ago

Summary

This fixes the off by 1 error in the Riemann initial conditions for 1D and 2D setups. There's still boundary condition issues and even with this fix the code produces all NaNs after the first time step. See Issue #313 for discussion

To Do

[x] Fix Riemann initial conditions
[ ] Fix boundary conditions check failing
[ ] Fix NaNs after first time step
[ ] Add 1D and 2D sod tests

bcaddy commented 11 months ago

Addressed in PR #315