cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Refactor concatenation scripts to make them importable and to give them a CLI #351

Closed bcaddy closed 7 months ago

bcaddy commented 8 months ago

It would be nice if all the concatenation scripts could be easily imported into another python script and if they had a CLI for ease of use rather than copying and editing. I've already refactored cat_dset_3d.py and cat_slice.py like this (see PRs #347 and #303) but the others need it too. I'm planning on working on this during our next hack session.

Importable versions already exist in cat.py courtesy of @alwinm, per an offline discussion Alwin and I decided that the method used in cat_slice.py and cat_dset_3d.py is probably better long term so we should update the other scripts to be like them.

bcaddy commented 7 months ago

Resolved in PR #347