search

cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Set launch parameters of some high cost kernels automatically #359

Closed bcaddy closed 5 months ago

bcaddy commented 6 months ago

Automatically Set Number of Blocks and Threads

I applied AutomaticLaunchParams to all the kernels called in the VL_3D integrator. Ended up with a 10-15% improvement in performance on MHD with both a V100 and MI250X. I can apply it to other places or time consuming kernels if anyone wants me to.

v100_run_timing.log frontier_run_timing.log

Resolves #232

Updated MHD Default Build Type

Removed density and temperature floors from default MHD builds

AutomaticLaunchParams

Updated some comments to be inline with current code.

evaneschneider commented 5 months ago

Looks good to me!