cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Update Most Builds to VL+PLMC #364

Closed bcaddy closed 5 months ago

bcaddy commented 5 months ago

Summary

Updated all builds, except cosmology, to use the Van Leer (VL) integrator and Piecewise Linear Method in the Characteristic variables (PLMC) reconstruction.

I'd like @helenarichie and @ojwg to take a look to make sure I'm not breaking any of their builds.

evaneschneider commented 5 months ago

Just to double-check -- were you able to confirm that the spherical collapse test is actually collapsing now? It was working when I initially added the system test, but when @evazlimen documented it last August it was not.

bcaddy commented 5 months ago

I compared slices of the old and new fiducial data and there were qualitatively very similar; ie a big dot in the middle. I thought the old fiducial data was definitely correct but I’m not totally sure.

evaneschneider commented 5 months ago

Sounds good. If you could add a plot of the new slice data to the documented examples page, that would be great (ultimately we will need to do this for all the examples, but that's a longer-term project).

bcaddy commented 5 months ago

Sure. I assume you want a higher resulting plot like 128^3 or 256^3 rather than the low res test version?

evaneschneider commented 5 months ago

Yes, I think specifically the plot that results from using the example parameter file (which is 256^3).