search

cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Add MHD Support to Projection and Rotated Projection Outputs #366

Closed bcaddy closed 5 months ago

bcaddy commented 5 months ago

Summary

Per the discussion in PR #365 I've added MHD support to the projection and rotated projection outputs along with a minor refactor to those functions to accomplish this and utilize more of the utility functions we've written.

I also added a utility function for computing the temperature from the conserved variables (hydro_utilities::Calc_Temp_Conserved). Internally it simply calls hydro_utilities::Calc_Pressure_Conserved and hydro_utilities::Calc_Temp to compute the temperature.

Duel Energy + Dust Fixes

Dust_Kernel had few DE related bugs in it that I fixed with help from @helenarichie. While doing that I also slightly redefined hydro_utilities::Calc_Temp_DE to take the total gas energy instead of the specific gas energy and density.

bcaddy commented 5 months ago

I believe those things are done now.

bcaddy commented 5 months ago

Everything is passing except a single clang-tidy warning in unrelated code. I don't know why that warning didn't pop up in a previous PR but it is fixed in PR #364. IMO, either that PR should be merged in first or this one is OK to merge.