cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Remove Monotonization in PLMC #376

Closed bcaddy closed 3 months ago

bcaddy commented 4 months ago

This monotonization is no longer required after the bug fix in the utility functions and it too often reduces the method to first order so we're removing it. I also had to update many of the system tests for this change. See #361 for more info on the bug fixes.

To catch these kinds of issues in the future I added a system test for the Kelvin Helmholtz instability since during testing it showed the issue quite noticeably.