cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Cosmology System Test & Gravity Support in `SystemTestRunner` Class #390

Closed bcaddy closed 5 days ago

bcaddy commented 2 months ago

Summary

evaneschneider commented 2 weeks ago

Is this ready to be merged? There is still a conflict with the test data.

bcaddy commented 2 weeks ago

I fixed the conflict. I'm running into a weird bug with some tests with DE turned on failing. I'll let you know when I have that resolved

bcaddy commented 2 weeks ago

This is ready to merge.

The bug was due to cosmology using a different value of DE_ETA_1 which changed the pressure in some tests. I've added handling for this to those tests.

evaneschneider commented 5 days ago

Just so I understand, which tests exactly did you need to change? The change by several orders of magnitude in the pressure is surprising to me, but maybe it's because I don't understand what is being compared.

bcaddy commented 5 days ago

tALLLoadCellPrimitive and tALLReconstructionLoadData. DE_ETA_1 is very different in cosmology builds so which leads to the difference.

evaneschneider commented 5 days ago

I'm still not understanding. Don't those tests just load in fidicuial data? So why is the data different? I understand that the eta value is different, but I'm not understanding what the test data represents.

bcaddy commented 5 days ago

Both of the functions being tested call the "get pressure from DE" function which internally depends on the value of DE_ETA_1 and the difference in that is enough with this fiducial data to change how it's handled.

evaneschneider commented 5 days ago

I see, thank you.