Closed bcaddy closed 5 days ago
Is this ready to be merged? There is still a conflict with the test data.
I fixed the conflict. I'm running into a weird bug with some tests with DE turned on failing. I'll let you know when I have that resolved
This is ready to merge.
The bug was due to cosmology using a different value of DE_ETA_1
which changed the pressure in some tests. I've added handling for this to those tests.
Just so I understand, which tests exactly did you need to change? The change by several orders of magnitude in the pressure is surprising to me, but maybe it's because I don't understand what is being compared.
tALLLoadCellPrimitive
and tALLReconstructionLoadData
. DE_ETA_1
is very different in cosmology builds so which leads to the difference.
I'm still not understanding. Don't those tests just load in fidicuial data? So why is the data different? I understand that the eta value is different, but I'm not understanding what the test data represents.
Both of the functions being tested call the "get pressure from DE" function which internally depends on the value of DE_ETA_1
and the difference in that is enough with this fiducial data to change how it's handled.
I see, thank you.
Summary
SystemTestRunner
classcombine_hydro_particles.py
script to work with gravity files as well. Now namedcombine_test_files.py