cholla-hydro / cholla

A GPU-based hydro code
https://github.com/cholla-hydro/cholla/wiki
MIT License
60 stars 32 forks source link

Merge All Three PPM Kernels Into One #392

Open bcaddy opened 2 months ago

bcaddy commented 2 months ago

Summary

This merges the PPMC_CTU, PPMC_VL, and PPMP kernels into one single kernel.

PPMC/PPMP Merge

Accuracy & Stability

Similar to PR #391 I ran as suite of tests to verify stability and correctness. PPM is generally more oscillatory than PLM and the implosion test is not working either before or after this refactor; in fact it's not working on dev either.

mhd_ppm_tests.zip hydro_ppm_tests.zip

Dependencies

Depends on PRs #371, #375, #377, and #391. Until those are merged this will look like it has a lot more changes than it does. A version without all those extra changes can be found here.