chonton / exists-maven-plugin

Check if artifact exists in remote maven repository
Apache License 2.0
47 stars 18 forks source link

Version 0.9.0 - cmpChecksum doesn't work when using Amazon S3 #41

Closed tobias-hammerschmidt closed 1 year ago

tobias-hammerschmidt commented 1 year ago

I think this is most likely the same root cause as in #37. The files are present and the scenario is working with version 0.5.0. Although version 0.8.0 fixes the access for the the artifact itself the checksum files still seem to be fetched with an extra / (being encoded as %2F in the request):

image

chonton commented 1 year ago

try version 0.11.0

tobias-hammerschmidt commented 1 year ago

Still the same behavior in 0.11.0. Just had a look at the code - maybe https://github.com/chonton/exists-maven-plugin/blob/22e033ac34ca9b96b2111f12b2e359a400063797/src/main/java/org/honton/chas/exists/RemoteExistsMojo.java#L276 is missing the handling of leading slashes like in https://github.com/chonton/exists-maven-plugin/blob/22e033ac34ca9b96b2111f12b2e359a400063797/src/main/java/org/honton/chas/exists/RemoteExistsMojo.java#L263?

chonton commented 1 year ago

Thanks for the suggestion, please try 0.12.0

tobias-hammerschmidt commented 1 year ago

I can confirm that the scenario is working again with 0.12.0.