search

choojs / bankai

:station: - friendly web compiler
Apache License 2.0
1.09k stars 102 forks source link

🔦Where would bankai check for favicon.ico? #490

Closed ZhouHansen closed 6 years ago

ZhouHansen commented 6 years ago

This is a 🔦question

Adding favicon is a todo task. So where would bankai check for favicon.ico, assets/, root directory or both?

goto-bus-stop commented 6 years ago

Hmmm :thinking: I think the root directory would be best, because assets/ is served as mywebsite.net/assets and the favicon should probably be at mywebsite.net/favicon.ico instead.

ZhouHansen commented 6 years ago

Thanks for your suggestion.