choojs / bankai

:station: - friendly web compiler

Apache License 2.0

1.09k stars 102 forks source link

🐛Apply sheetify and glslify after babelify #511

Open real-alexei opened 6 years ago

real-alexei commented 6 years ago

Looks like otherwise Babelify is applied after subject transforms.

This requires https://github.com/stackcss/sheetify/pull/156 to be merged first in order to purifycss is able to cleanup transpiled templates code. @yoshuawuyts Please take a look at it.

real-alexei commented 6 years ago

345 should be fixed by this.

real-alexei commented 5 years ago

@yoshuawuyts Should be good now. Please take a look. Thanks!

goto-bus-stop commented 5 years ago

IIRC this was a potentially breaking change for some reason. I can check #choo chat logs later to see if it was mentioned why. We should do it though, but ideally without running sheetify and glslify as global transforms. We can remove the global: true from the babelify transform for the user's own code, remove the tfilter thing from it, and move it to the start.